Allow for timestamps before the epoch #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @markhuot, thank you for the suggestion; I didn't know about this usage of the timestamp. It makes sense to me: please add tests to the PR, and I will be happy to merge it. 🙂 |
romm
reviewed
Nov 30, 2022
| @@ -44,7 +44,7 @@ public function __construct(string $format, string ...$formats) | |||
|
|
|||
| /** | |||
| * @param class-string<DateTime|DateTimeImmutable> $className | |||
| * @param non-empty-string|positive-int $value | |||
| * @param non-empty-string $value | |||
There was a problem hiding this comment.
Suggested change
| * @param non-empty-string $value | |
| * @param non-empty-string|int $value |
|
Thank you guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this is the right fix but timestamps can technically be negative numbers. I have some dates that I'm importing that range back to 1920 and am currently getting an error that
Value {source_value} does not match any of 'non-empty-string', 'positive-int'for the value-450734400.If you agree with this change I can expand the PR, update the tests, etc.