fix: remove exception inheritance from UnresolvableType
#386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `UnresolvableType` can be applied to any property, parameter or function/method return type, it can be present in a class definition hierarchy. This class definition can then be cached for better application performance, meaning these `UnresolvableType` will be present in the cache entry. This is a problem because an exception contains a lot of information, including reflection instances which can not be serialized and can break caching mechanisms that rely on serialization. `UnresolvableType` extending `LogicException` was not necessary, so it is removed and the code relying on it has been adapted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
UnresolvableTypecan be applied to any property, parameter or function/method return type, it can be present in a class definition hierarchy. This class definition can then be cached for better application performance, meaning theseUnresolvableTypewill be present in the cache entry. This is a problem because an exception contains a lot of information, including reflection instances which can not be serialized and can break caching mechanisms that rely on serialization.UnresolvableTypeextendingLogicExceptionwas not necessary, so it is removed and the code relying on it has been adapted.