Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow any constant in class constant type #520

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

romm
Copy link
Member

@romm romm commented Apr 7, 2024

The following annotation is now allowed:

final class SomeClass
{
    public const FOO = 'foo';
    public const BAR = 42;
}

(new \CuyZ\Valinor\MapperBuilder())
    ->mapper()
    ->map('SomeClass::*', 'foo'); // ✅

The following annotation is now allowed:

 ```php
 final class SomeClass
 {
     public const FOO = 'foo';
     public const BAR = 42;
 }

 (new \CuyZ\Valinor\MapperBuilder())
     ->mapper()
     ->map('SomeClass::*', 'foo'); // ✅
```
@romm romm merged commit 6942755 into CuyZ:master Apr 7, 2024
11 checks passed
@romm romm deleted the fix/allow-any-class-const branch April 7, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant