fix: skip node build for NullType when value is not null #526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.11 revamped union types but also deleted a fast path present in 1.10. In our use cases with many large objects with many nullable properties, this caused execution times to nearly double, especially with XDebug enabled.
The following test case sees its execution time drop from ~6.7 seconds to ~3.6 seconds on my local machine with the included patch. Profiling the test sees a reduction of node build calls to nearly half the original value.