feat: add microseconds support to timestamp format #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoSector
force-pushed
the
feature/microsecond-support-for-datetime-timestamps
branch
from
8a0a7be
to
7cf8cac
Compare
Prior to this patch, this would require a custom constructor in the form
of:
```php
static fn(float | int $timestamp): DateTimeImmutable => new
DateTimeImmutable(sprintf("@%d", $timestamp)),
```
This bypasses the datetime format support of Valinor entirely. This is
required because the library does not support floats as valid
DateTimeInterface input values.
This commit adds support for floats and registers timestamp.microseconds
(U.u) as a valid default format.
romm
force-pushed
the
feature/microsecond-support-for-datetime-timestamps
branch
from
7cf8cac
to
780d342
Compare
|
Excellent! Thanks you @NanoSector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, this would require a custom constructor in the form of:
This bypasses the datetime format support of Valinor entirely. This is required because the library does not support floats as valid DateTimeInterface input values.
This PR adds support for floats and registers timestamp.microseconds (U.u) as a valid default format.