Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 compatibility #551

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Add PHP 8.4 compatibility #551

merged 1 commit into from
Sep 16, 2024

Conversation

Slamdunk
Copy link
Contributor

@Slamdunk Slamdunk commented Aug 8, 2024

Fixes 2 issues:

CuyZ\Valinor\Mapper\Tree\Shell::child(): Implicitly marking parameter $attributes as nullable is deprecated, the explicit nullable type must be used instead
CuyZ\Valinor\Type\Types\ClassStringType::__construct(): Implicitly marking parameter $subType as nullable is deprecated, the explicit nullable type must be used instead

See https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

This PR doesn't add PHP 8.4 support, it just makes it runnable in PHP 8.4 without errors.

@romm
Copy link
Member

romm commented Sep 16, 2024

Thank you @Slamdunk!

@romm romm merged commit 304db39 into CuyZ:master Sep 16, 2024
11 checks passed
@Slamdunk Slamdunk deleted the php_84_compat branch September 16, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants