addressing issue #388. Checking if URL is null, empty, or blank (usin…

…g Java 1.8 compatibility) Signed-off-by: mtgag <githreg@mtg.de>
CycloneDX · Sep 14, 2023 · c08b9c7 · c08b9c7
1 parent 71c467e
commit c08b9c7
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/main/java/org/cyclonedx/maven/DefaultModelConverter.java b/src/main/java/org/cyclonedx/maven/DefaultModelConverter.java
@@ -269,7 +269,7 @@ private MavenProject getEffectiveMavenProject(final Artifact artifact) throws Pr
  }
 
  private void addExternalReference(final ExternalReference.Type referenceType, final String url, final Component component) {
- if (url == null || doesComponentHaveExternalReference(component, referenceType)) {
+ if (isURLBlank(url) || doesComponentHaveExternalReference(component, referenceType)) {
  return;
  }
  try {
@@ -398,4 +398,8 @@ private Component.Type resolveProjectType(String projectType) {
  }
  return Component.Type.LIBRARY;
  }
+
+ private static boolean isURLBlank(String url) {
+ return url == null || url.isEmpty() || url.trim().length() == 0;
+ }
 }