Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing issue #388. Checking if URL is null, empty, or blank (usin… #396

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Addressing issue #388. Checking if URL is null, empty, or blank (usin… #396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/org/cyclonedx/maven/DefaultModelConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ private MavenProject getEffectiveMavenProject(final Artifact artifact) throws Pr
}

private void addExternalReference(final ExternalReference.Type referenceType, final String url, final Component component) {
if (url == null || doesComponentHaveExternalReference(component, referenceType)) {
if (isURLBlank(url) || doesComponentHaveExternalReference(component, referenceType)) {
return;
}
try {
Expand Down Expand Up @@ -398,4 +398,8 @@ private Component.Type resolveProjectType(String projectType) {
}
return Component.Type.LIBRARY;
}

private static boolean isURLBlank(String url) {
return url == null || url.isEmpty() || url.trim().length() == 0;
}
}