Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classifier used to attach the sbom should be configurable #433

Closed
wants to merge 1 commit into from

Conversation

olamy
Copy link
Contributor

@olamy olamy commented Nov 18, 2023

currently it is hardcoded to cyclonedx. It would be nice to have it configurable something such sbom looks more appropriate.

Signed-off-by: Olivier Lamy <olamy@apache.org>
@hboutemy
Copy link
Contributor

hboutemy commented Nov 18, 2023

this PR is simple, I don't have any problem with its code
my only fearing is that there is currently a naming convention that has been used to publish much content to Maven Central: is it a good idea to change?
and FYI, cyclonedx os not the only SBOM format on earth
if you really feel you are adding value to Jetty by creating your own value that nobody else uses and that hides what concrete format your project chose, tell me and I'll merge: this is simple enough

please think twice :)

@olamy
Copy link
Contributor Author

olamy commented Nov 19, 2023

ah you're right I forgot the story about different standards.

standards-proliferation

definitely not needed for Jetty

@hboutemy
Copy link
Contributor

integrated in #506

@hboutemy hboutemy closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants