Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configuration option to skip undeployed artifacts #435

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

ppkarwasz
Copy link
Contributor

This adds a <skipNotDeployed> plugin configuration option. If set to false, even artifacts that do not have a deploy execution are used to generate the SBOM.

Closes #430

This adds a `<skipNotDeployed>` plugin configuration option. If set to
`false`, even artifacts that do not have a deploy execution are used to
generate the SBOM.

Closes CycloneDX#430

Signed-off-by: Piotr P. Karwasz <piotr.github@karwasz.org>
@bstrdsmkr
Copy link

+1 for this, it fixes a ton of our builds that were broken by the implementation of the previous feature

@hboutemy hboutemy merged commit e6b6af2 into CycloneDX:master Dec 13, 2023
3 checks passed
@hboutemy
Copy link
Contributor

great job, thank you

hboutemy added a commit that referenced this pull request Dec 13, 2023
@ppkarwasz ppkarwasz deleted the skip-undeployed branch December 13, 2023 18:34
@ankursharma180
Copy link

ankursharma180 commented Jan 3, 2024

@hboutemy Thanks for this change, If you can provide some updates, when there will be a 2.7.11 release ?

@hboutemy
Copy link
Contributor

hboutemy commented Jan 4, 2024

there are 2 PRs I want to merge before doing the release: I hope we'll get that done soon

@ankursharma180
Copy link

Okay, thank you.
Really a great work. Thanks again. :-)
Waiting for this new release.

@olgti
Copy link

olgti commented Mar 21, 2024

@ppkarwasz @hboutemy I'm executing mvn with this line: mvn org.cyclonedx:cyclonedx-maven-plugin:2.7.11:makeAggregateBom -DskipNotDeployed=false
However the project without deploy still being skipped: --- cyclonedx-maven-plugin:2.7.11:makeAggregateBom (default-cli) @ sfci-p2p ---
[INFO] Skipping CycloneDX goal, because module skips deploy

Any suggestions? Am I passing the param incorrectly? Thanks

@MukhachevDima
Copy link

@ppkarwasz @hboutemy I'm executing mvn with this line: mvn org.cyclonedx:cyclonedx-maven-plugin:2.7.11:makeAggregateBom -DskipNotDeployed=false However the project without deploy still being skipped: --- cyclonedx-maven-plugin:2.7.11:makeAggregateBom (default-cli) @ sfci-p2p --- [INFO] Skipping CycloneDX goal, because module skips deploy Any suggestions? Am I passing the param incorrectly? Thanks

Hello! Your problem is probably already resolved. But for anyone who has the same problem: you should run maven with arg -Dcyclonedx.skipNotDeployed=false. This helped me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possiblity to create SBOM even for not deployed artifacts
6 participants