-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tdvp example and add Lanczos benchmark: #437
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hunghaoti
commented
May 23, 2024
- Fix the tdvp example code to correct order.
- Add benchmark test for Lanczos_Gnd and Lanczos_Exp.
1. Fix the tdvp example code to correct order. 2. Add benchmark test for Lanczos_Gnd and Lanczos_Exp.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-master #437 +/- ##
==============================================
+ Coverage 16.47% 16.58% +0.11%
==============================================
Files 220 221 +1
Lines 48172 48453 +281
Branches 20035 20255 +220
==============================================
+ Hits 7937 8038 +101
- Misses 36105 36135 +30
- Partials 4130 4280 +150 ☔ View full report in Codecov by Sentry. |
Dev master
…/Cytnx into haoti/fix_tdvp_example
Store the Krylov subspace vectors if is_V is true, to avoid second round construction of the Krylov subspace.
Optimize Lanczos method by storing the Krylov subspace vectors in the first iteration. |
kaihsin
requested changes
Jul 18, 2024
kaihsin
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.