Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tdvp example and add Lanczos benchmark: #437

Merged
merged 8 commits into from
Jul 26, 2024

Conversation

hunghaoti
Copy link
Collaborator

  1. Fix the tdvp example code to correct order.
  2. Add benchmark test for Lanczos_Gnd and Lanczos_Exp.

1. Fix the tdvp example code to correct order.
2. Add benchmark test for Lanczos_Gnd and Lanczos_Exp.
@hunghaoti hunghaoti requested review from jeffry1829 and j9263178 May 23, 2024 09:57
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 24 lines in your changes missing coverage. Please review.

Project coverage is 16.58%. Comparing base (87126bf) to head (47984fc).
Report is 20 commits behind head on dev-master.

Files Patch % Lines
src/linalg/Lanczos_Gnd_Ut.cpp 7.69% 5 Missing and 19 partials ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           dev-master     #437      +/-   ##
==============================================
+ Coverage       16.47%   16.58%   +0.11%     
==============================================
  Files             220      221       +1     
  Lines           48172    48453     +281     
  Branches        20035    20255     +220     
==============================================
+ Hits             7937     8038     +101     
- Misses          36105    36135      +30     
- Partials         4130     4280     +150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hunghaoti and others added 4 commits July 16, 2024 11:39
Store the Krylov subspace vectors if is_V is true, to avoid second round construction of the Krylov subspace.
@hunghaoti hunghaoti requested a review from kaihsin July 16, 2024 09:18
@hunghaoti
Copy link
Collaborator Author

Optimize Lanczos method by storing the Krylov subspace vectors in the first iteration.

src/linalg/Lanczos_Gnd_Ut.cpp Outdated Show resolved Hide resolved
@hunghaoti hunghaoti requested a review from kaihsin July 23, 2024 04:02
@hunghaoti hunghaoti merged commit 27e8ed4 into dev-master Jul 26, 2024
4 checks passed
@hunghaoti hunghaoti deleted the haoti/fix_tdvp_example branch July 26, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants