Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev master to master #453

Merged
merged 56 commits into from
Aug 30, 2024
Merged

Dev master to master #453

merged 56 commits into from
Aug 30, 2024

Conversation

jeffry1829
Copy link
Collaborator

No description provided.

j9263178 and others added 30 commits December 5, 2023 23:48
Change API Lanczos_Exp_Ut to Lanczos_Exp. (Consistent with Lanczos API)
1. Modify the algorithm of Lanczos Exp so that it can simulate for non positive case.
2. Add example code for 1tdvp algorithm and pytest.
Fix the wrong path for CUQUANTUM cmake.
1. Fix the tdvp example code to correct order.
2. Add benchmark test for Lanczos_Gnd and Lanczos_Exp.
jeffry1829 and others added 23 commits June 7, 2024 00:16
Store the Krylov subspace vectors if is_V is true, to avoid second round construction of the Krylov subspace.
1. Fix tdvp example and add Lanczos benchmark.
2. Optimize the Lanczos algorithm to simulate the ground state.
add svd_truncate mindim capability
Ensured the build process successful with CUDA enabled.
`cutensorContraction()` has only supported floating-point types at least
since version 1.6.2.

Refferce: https://docs.nvidia.com/cuda/cutensor/1.6.2/api/cutensor.html#cutensorcontraction
Because cuQuantum 23.x requires cuTENSOR v1.6.1+ (and < 2.0.0) which is
not compatible with cuTENSOR 2.x, the oldest supported cuQuantum will be
24.x after this commit.

Referrences:
- [Transition to cuTENSOR 2.x](https://docs.nvidia.com/cuda/cutensor/2.0.2/api_transition.html)
- [cuQuantum's dependencies](https://docs.nvidia.com/cuda/cuquantum/23.10.0/getting_started/getting_started.html#dependencies-cutensornet-label)
@jeffry1829 jeffry1829 requested a review from j9263178 August 30, 2024 07:11
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 21.63866% with 373 lines in your changes missing coverage. Please review.

Project coverage is 16.56%. Comparing base (e518b8b) to head (5d37d81).
Report is 64 commits behind head on master.

Files with missing lines Patch % Lines
src/linalg/Lanczos_Exp.cpp 7.29% 107 Missing and 71 partials ⚠️
src/linalg/Arnoldi.cpp 36.03% 1 Missing and 70 partials ⚠️
src/RegularNetwork.cpp 30.55% 5 Missing and 20 partials ⚠️
src/linalg/Lanczos_Gnd_Ut.cpp 7.69% 5 Missing and 19 partials ⚠️
src/UniTensor_base.cpp 26.66% 22 Missing ⚠️
include/UniTensor.hpp 32.25% 14 Missing and 7 partials ⚠️
src/BlockUniTensor.cpp 33.33% 9 Missing and 1 partial ⚠️
src/DenseUniTensor.cpp 53.33% 6 Missing and 1 partial ⚠️
src/linalg/Gesvd_truncate.cpp 0.00% 2 Missing and 3 partials ⚠️
src/linalg/Svd_truncate.cpp 16.66% 1 Missing and 4 partials ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   16.49%   16.56%   +0.07%     
==========================================
  Files         220      221       +1     
  Lines       48275    48481     +206     
  Branches    20126    20264     +138     
==========================================
+ Hits         7961     8030      +69     
+ Misses      36183    36176       -7     
- Partials     4131     4275     +144     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeffry1829 jeffry1829 merged commit fa4596e into master Aug 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants