Suppress clang error

[IvanaGyro]

This PR eases the problem of #449.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 16.60%. Comparing base (dea928d) to head (72453ca).
Report is 14 commits behind head on dev-master.

Files with missing lines	Patch %	Lines
src/backend/linalg_internal_cpu/Det_internal.cpp	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           dev-master     #461   +/-   ##
===========================================
  Coverage       16.60%   16.60%           
===========================================
  Files             221      221           
  Lines           48486    48490    +4     
  Branches        20271    20272    +1     
===========================================
+ Hits             8052     8053    +1     
- Misses          36141    36143    +2     
- Partials         4293     4294    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kaihsin]

Actually maybe I miss something but what exactly is the issue?

[kaihsin]

[ 83%] Building CXX object CMakeFiles/cytnx.dir/src/backend/linalg_internal_cpu/Ger_internal.cpp.o
/Users/pcchen/github/Cytnx/src/backend/linalg_internal_cpu/Det_internal.cpp:31:36: error: implicit conversion from '_Complex double' to 'double' is not permitted in C++
        od[0] *= (cytnx_complex128)_Rin[i * N + i];

It seems the issue is the implicit cast upon calling *= where its going from complex to double? (specifically od[0] is double and someone try to do this op?) Then I am not sure the fix in this OR goes into the root of problem? @IvanaGyro maybe you can put some more insight on what happends?

[IvanaGyro]

[ 83%] Building CXX object CMakeFiles/cytnx.dir/src/backend/linalg_internal_cpu/Ger_internal.cpp.o
/Users/pcchen/github/Cytnx/src/backend/linalg_internal_cpu/Det_internal.cpp:31:36: error: implicit conversion from '_Complex double' to 'double' is not permitted in C++
        od[0] *= (cytnx_complex128)_Rin[i * N + i];

It seems the issue is the implicit cast upon calling *= where its going from complex to double? (specifically od[0] is double and someone try to do this op?) Then I am not sure the fix in this OR goes into the root of problem? @IvanaGyro maybe you can put some more insight on what happends?

Sorry, I don't have a Mac device. This original problem of implicit conversion only happens on Mac. Implicit conversion should not happen. Here is the comment I left in the issue. #449 (comment)

[kaihsin]

Yes. That's what I was asking for agnostic implementation. It needs to take all those deps into consideration. And previous solution is to use macro ( actually idk if there is any other solutions even exist in C/C++) to deal with this

…

On Mon, Sep 2, 2024, 01:23 Ivana ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/backend/linalg_internal_cpu/Det_internal.cpp <#461 (comment)>: > @@ -27,8 +31,8 @@ namespace cytnx { "[ERROR][Det_internal] Error in Lapack function 'zgetrf': Lapack INFO = ", info); od[0] = 1; bool neg = 0; - for (lapack_int i = 0; i < N; i++) { - od[0] *= (cytnx_complex128)_Rin[i * N + i]; + for (int i = 0; i < N; i++) { Updated — Reply to this email directly, view it on GitHub <#461 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFCX3SL3XRE73G5D7NTTUVTZUPY4FAVCNFSM6AAAAABNOVPMI6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENZUGY4TKNBRGQ> . You are receiving this because you commented.Message ID: ***@***.***>

[pcchen]

I would like to suggest to keep this kind of technical note somewhere in the repository.

[IvanaGyro]

I would like to suggest to keep this kind of technical note somewhere in the repository.

Mentioned in the comment in the latest update.

The commits are updated.