Add test for Storage::append() with reallocation
#509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we want to create a test case testing with all combinations of
the supported data types. There is a test checking if the value of
each data type can be filled into the `Storage` instance storing the
values in every supported data type. One way to make this kind of test
case but not to duplicate the test cases for each combination of types
is to use gtest's typed-test feature which needs us to list all
combinations of types.
```cpp
using MyTypes = ::testing::Types<std::pair<int, double>,
std::pair<int, bool>,
std::pair<double, double>,
std::pair<double, bool>>;
TYPED_TEST_SUITE(MyFixture, MyTypes);
TYPED_TEST(TestSuiteName, TestName) {
using FirstType = TypeParam::first_type;
using SecondType = TypeParam::second_type;
//...
}
```
In the example `MyTypes` contains the combination of two groups of
types. The first group is `int` and `double`, and the second group is
`double` and `bool`. If there are ten supported types, there will be one
hundred pairs in `MyTypes`. Writing that kind of code is exhausting,
and the code will be hard to maintain.
This change provides a tool for generating all combinations of the given
testing types and makes writing tests more easily.
The previous tests were limited to integral data types. The new tests verify that filling all Storage types with a value of any supported data type behaves correctly.
Test with all Storage types and all data types.
IvanaGyro
force-pushed
the
test-storage-append
branch
from
4f9215f to
c7effd2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-master #509 +/- ##
==============================================
+ Coverage 16.78% 18.11% +1.33%
==============================================
Files 221 221
Lines 53173 53173
Branches 19822 19823 +1
==============================================
+ Hits 8923 9634 +711
+ Misses 39940 39003 -937
- Partials 4310 4536 +226 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
kaihsin
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also extends the test coverage of
Storage::fill().