Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake configuration for the location of the test data #523

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

IvanaGyro
Copy link
Collaborator

@IvanaGyro IvanaGyro commented Nov 29, 2024

This is a PR that rebases #513 onto the dev branch. Please see #513 for the details.

tests/CMakeLists.txt: add CYTNX_TEST_DATA_DIR variable for the location of the test data root directory

Update all tests that reference the test data directory to load data from CYTNX_TEST_DATA_DIR
Confirmed works for the CPU tests and GPU tests
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.54%. Comparing base (e537d60) to head (24b1bbe).
Report is 26 commits behind head on dev-master.

Additional details and impacted files
@@              Coverage Diff               @@
##           dev-master     #523      +/-   ##
==============================================
- Coverage       16.74%   16.54%   -0.20%     
==============================================
  Files             211      211              
  Lines           49014    48829     -185     
  Branches        18712    18900     +188     
==============================================
- Hits             8205     8080     -125     
+ Misses          36660    36603      -57     
+ Partials         4149     4146       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@manuschneider manuschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on my system, also if I move the test data folder elsewhere and change the path in tests/CMakeLists.txt file accordingly.

@IvanaGyro IvanaGyro merged commit c1aa24b into dev-master Nov 29, 2024
4 checks passed
@IvanaGyro IvanaGyro deleted the fix-test-data-dir branch November 29, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants