Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: use local mit-tr instead of MIT self-hosted #16

Closed
wants to merge 2 commits into from

Conversation

YohannParis
Copy link
Member

Description

  • Needs to be merged after orchestration PR that change MIT_TR_URL from mit-hosted to mit-tr.
  • Remove OPEN_AI_KEY as it is embedded as an ENV in orchestration for mit-tr

To be honest I don't know if we want to make that OPEN_AI_KEY optional in case someone (MIT) is not running their mit-tr container with an already set key?

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #16 (3377ee6) into main (2c32c25) will decrease coverage by 0.15%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   81.78%   81.63%   -0.15%     
==========================================
  Files           5        5              
  Lines         505      501       -4     
==========================================
- Hits          413      409       -4     
  Misses         92       92              
Files Changed Coverage Δ
api/server.py 90.76% <ø> (ø)
api/utils.py 74.60% <ø> (ø)
workers/operations.py 74.67% <100.00%> (-0.43%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YohannParis
Copy link
Member Author

This is still needed as mit-tr is poorly written and we cannot really leverage ENV variables.

@YohannParis YohannParis deleted the use_local_mit branch August 21, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant