renamed TA1-service to Knowledge-Middleware #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fivegrant would you mind merging this into your open PR? I suspect there may be some conflicts to resolve |
YohannParis
reviewed
Aug 29, 2023
There was a problem hiding this comment.
This file should not be changed because it is the one calling the TA1 services!
There was a problem hiding this comment.
that's a good catch--we already merged this but can update it. we may want our logging to be more explicit in saying "MIT" or "SKEMA" instead of "TA1" (or now "Knowledge Service")
|
Closing this as it was rebased into and included in #23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #(issue)