Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker utils changes to always create a config in TDS. #48

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Worker utils changes to always create a config in TDS. #48

merged 3 commits into from
Sep 12, 2023

Conversation

Sorrento110
Copy link
Contributor

Description

  • Moved the configuration creation to always happen at the end of the put_amr_to_tds process.
  • Changed how configuration name and description are initialized to make it more consistent (since they are required by TDS).

Resolves #43

@Sorrento110 Sorrento110 linked an issue Sep 11, 2023 that may be closed by this pull request
Create default model config for equation to AMR #43
Closed
fivegrant
fivegrant reviewed Sep 12, 2023
View reviewed changes
tests/test_e2e.py Outdated Show resolved Hide resolved
brandomr
brandomr reviewed Sep 12, 2023
View reviewed changes
worker/utils.py Show resolved Hide resolved
worker/utils.py Outdated Show resolved Hide resolved
worker/utils.py Show resolved Hide resolved
worker/utils.py Show resolved Hide resolved
tests/test_e2e.py Show resolved Hide resolved
tests/test_e2e.py Outdated Show resolved Hide resolved
@Sorrento110
Addressed requested changes, added test assertions for configuration …
71d0766 
…creation for both use cases of equation to amr.
fivegrant
fivegrant approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@fivegrant fivegrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sorrento110 Sorrento110 merged commit 72caff2 into main Sep 12, 2023
1 check passed
@Sorrento110 Sorrento110 deleted the 43-create-default-model-config-for-equation-to-amr branch September 12, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandomr brandomr brandomr approved these changes

@fivegrant fivegrant fivegrant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create default model config for equation to AMR
3 participants
@Sorrento110 @brandomr @fivegrant