Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that cards are required in scenarios #61

Closed
wants to merge 1 commit into from

Conversation

fivegrant
Copy link
Collaborator

@fivegrant fivegrant commented Sep 22, 2023

model_card.json and data_card.json are used in the tests for data and model cards however they weren't listed as resources in resource.yaml

@brandomr
Copy link
Contributor

brandomr commented Sep 22, 2023

@fivegrant to me those are "ground truth artifacts" and for an integration test we should only need to be able to generate them not necessarily have them mocked. It's another example of live vs offline testing and the different cases. We may want to resource files...

@fivegrant fivegrant closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants