Optimize: add step size explicity. #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Szendrey
changed the title
mwdchang
reviewed
Jul 30, 2024
| ) # Need to pop this out of extra. | ||
| solver_method = extra_options.pop("solver_method") | ||
| if step_size is not None and solver_method == "euler": | ||
| solver_options = {"step_size": step_size} |
There was a problem hiding this comment.
Slightly better to not overwrite the entire dict:
solver_options["step_size"] = ...
mwdchang
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update optimize request to allow Derek to more easily utilize euler method.
DARPA-ASKEM/terarium#4318