Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bake #26

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Fix bake #26

merged 5 commits into from
Jul 31, 2023

Conversation

fivegrant
Copy link
Collaborator

Description

  • Include a summary of the changes and the related issue.
  • Include relevant motivation and context.

Resolves #(issue)

@brandomr
Copy link

@fivegrant this looks ok to me. I assume this will impact Uncharted's orchestration and deployment? Can you confirm that and if so, make sure it's on their radar?

@fivegrant
Copy link
Collaborator Author

@brandomr I fixed it to match their deployment so it should be the same images as before. The only breaking change is this:

Every operation saves 3 files to S3
- `result.csv`
- `eval.csv`
- `visualization.json`

Meaning we just standardized the output instead of switching between result.csv and simulation.csv. cc @Tom-Szendrey this means we might need a one line change on the PyCIEMSS calibrate and calibrate-ensemble endpoints.

@Tom-Szendrey
Copy link
Contributor

Thank you for this! This helps clear some confusion and mess

@fivegrant fivegrant changed the base branch from main to dev/1.6.0 July 31, 2023 15:21
@fivegrant
Copy link
Collaborator Author

Merging this change into a post-eval dev branch

@fivegrant fivegrant merged commit d86e182 into dev/1.6.0 Jul 31, 2023
1 check passed
fivegrant added a commit that referenced this pull request Aug 10, 2023
* Point to docker bake

* [broken] split back into separate images

* Split into two services properly

* Remove docker lint

* Fix README
@fivegrant fivegrant deleted the fix/build branch August 10, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants