Standardize PyCIEMSS installation across project #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PyCIEMSS was only being installed last second in the Dockerfile and lived entirely outside
pyproject.toml
.Project-wide installation is now necessary though because we want to start developing tests with PyCIEMSS.
Solution
Create a new task in
pyproject.toml
that installs PyCIEMSS in the Docker image, local dev environment, and GH Action.Unfortunately, PyTorch plays very poorly with Poetry so we are unable to specify it as a dependency. We instead have to
pip install
all of PyCIEMSS. There is a Poe the Poet task that is used to statefully install the library. Obviously, this isn't great but it's the cleanest solution available to us.Other changes
NOTICE
PLEASE RUN A
make init
TO TAKE ADVANTAGE OF THIS NEW CHANGE