Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize PyCIEMSS installation across project #34

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

fivegrant
Copy link
Collaborator

@fivegrant fivegrant commented Aug 11, 2023

Problem

PyCIEMSS was only being installed last second in the Dockerfile and lived entirely outside pyproject.toml.
Project-wide installation is now necessary though because we want to start developing tests with PyCIEMSS.

Solution

Create a new task in pyproject.toml that installs PyCIEMSS in the Docker image, local dev environment, and GH Action.

Unfortunately, PyTorch plays very poorly with Poetry so we are unable to specify it as a dependency. We instead have to pip install all of PyCIEMSS. There is a Poe the Poet task that is used to statefully install the library. Obviously, this isn't great but it's the cleanest solution available to us.

Other changes

  • Removed 'extra' group
  • Tests generated 'kwargs' against actual PyCIEMSS function signatures

NOTICE

PLEASE RUN A make init TO TAKE ADVANTAGE OF THIS NEW CHANGE

Copy link
Contributor

@mattprintz mattprintz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending clarification on question above.

@fivegrant fivegrant merged commit db24edd into main Aug 11, 2023
2 checks passed
@fivegrant fivegrant deleted the fg/pyciemss-install branch August 15, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants