Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E tests #36

Merged
merged 14 commits into from
Aug 17, 2023
Merged

Add E2E tests #36

merged 14 commits into from
Aug 17, 2023

Conversation

fivegrant
Copy link
Collaborator

@fivegrant fivegrant commented Aug 14, 2023

This PR runs through the whole flow for a given example. We use FakeRedis and the FastAPI testclient so we can actually run the flow without fully mocking everything. We can give RQ a connection to FakeRedis, enabling us to execute RQ within our tests.

We run the PyCIEMSS library live which has been helpful for debugging but it is a bit slow.

This PR does NOT test RabbitMQ or validate the requests being sent to TDS. These can be added in future tests. Furthermore, the faking mentioned above opens us up for more unit tests of the individual components

Other changes

  • Redis is now a FastAPI dependency
  • RabbitMQ warns instead of failing the entire operation

@fivegrant fivegrant linked an issue Aug 14, 2023 that may be closed by this pull request
@fivegrant fivegrant marked this pull request as ready for review August 17, 2023 16:52
Copy link
Contributor

@mattprintz mattprintz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fivegrant fivegrant merged commit 5304854 into main Aug 17, 2023
2 checks passed
@fivegrant fivegrant deleted the fg/integration-tests branch September 6, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ensemble notebook examples to PyCIEMSS tests
2 participants