terarium dataservice migration changes #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # service/execute.py # service/models.py # service/utils/tds.py # tests/integration/test_optimize_calibrate.py # tests/integration/test_optimize_simulate.py # tests/test_conversions.py
…service into dataservice-update
dgauldie
reviewed
Feb 1, 2024
mwdchang
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
As you may be aware
terariumhas inherited the tds datraservice endpoints. Some changes have been made while integrating it with the existing backend.Here is a small untested branch to assist in transitioning to the new endpoints. The changes are as follows:
kabob-caserather thansnake_case.camelCaserather thansnake_caseby default. Support for a"X-Enable-Snake-Case"header has been integrated which when provided will serialize / deserialize JSON keys assnake_case.idfields are nowuuid4types and will be generated server side. Types have an optional human friendlynamefield as well.service-userthat will be injected if the correct basic auth credential is added to each request. I've introducedTDS_USERandTDS_PASSWORDenv vars that will be injected in a basic auth header in each request. Please contact our team and we will provide the credential for our staging env. Please do not commit the credential to the repo unencrypted.Please let me know if there are any issues with this branch or you have any concerns.
Cheers