observable sanity check #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Szendrey
approved these changes
May 7, 2024
|
Just to add a note here. The Terarium API returns "observables = null" when the config is fetched with "X-Enable-Snake-Case" header, even though observables does not exist and does not appear in Terarium application itself. We can revert this PR when the API can return consistent responses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the weird cases where
observables == null, it creates minor issues downstream MIRA that is called by pyciemss. This force convert null-cases into empty list which is acceptable by MIRA.Note MIRA is aware of this and Ben G. he can make a fix on his end, so this is extra security until then.