Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ensemble simulate and calibrate. #133

Closed
wants to merge 5 commits into from

Conversation

jClugstor
Copy link
Collaborator

@jClugstor jClugstor commented Nov 6, 2023

Ensemble simulate now takes a collection of models and a collection of weights and constructs a solution which is a linear combination of the solutions and the weights. Ensemble calibrate does this in reverse, taking a dataset and a collection of models, and gives the weights that produce the dataset. Closes #109

@jClugstor jClugstor marked this pull request as draft November 7, 2023 20:00
@jClugstor
Copy link
Collaborator Author

This also adds tests for server routes.

@codecov-commenter
Copy link

Codecov Report

Merging #133 (9cd5c37) into main (1d4c836) will increase coverage by 0.54%.
Report is 9 commits behind head on main.
The diff coverage is 79.62%.

@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   77.99%   78.53%   +0.54%     
==========================================
  Files           3        3              
  Lines         409      452      +43     
==========================================
+ Hits          319      355      +36     
- Misses         90       97       +7     
Files Coverage Δ
src/SimulationService.jl 70.98% <70.58%> (+0.68%) ⬆️
src/operations.jl 88.26% <83.78%> (-0.50%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jClugstor jClugstor marked this pull request as ready for review November 8, 2023 18:40
@joshday
Copy link
Collaborator

joshday commented Nov 9, 2023

One thing we want is to have all the data/test cases live at https://github.com/darpa-askem/simulation-integration so that we don't need to maintain them, keep them in sync with the latest AMR versions, etc.

Can you split the JSON/CSV out from this PR and make a PR to add them in https://github.com/darpa-askem/simulation-integration? Then change the tests here to download what we need from there.

@jClugstor jClugstor closed this Dec 5, 2023
@jClugstor jClugstor deleted the ensemble-fixes branch December 5, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ensemble endpoints
3 participants