ci: cloud builder for multi arch builds #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nithos
force-pushed
the
cloud-builder
branch
from
224821a
to
4bee2fe
Compare
update bakefile targets as they are used for image naming
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
=======================================
Coverage 84.26% 84.26%
=======================================
Files 4 4
Lines 661 661
=======================================
Hits 557 557
Misses 104 104 ☔ View full report in Codecov by Sentry. |
Nithos
changed the title
dgauldie
reviewed
Feb 13, 2024
docker/docker-bake.hcl
Outdated
| @@ -28,26 +28,30 @@ function "check_suffix" { | |||
| # ---------------------------------------------------------------------------------------------------------------------- | |||
|
|
|||
| group "prod" { | |||
| targets = ["sciml-service"] | |||
| targets = ["simulation-service"] | |||
There was a problem hiding this comment.
how come you changed to simulation-service?
dgauldie
approved these changes
Feb 13, 2024
dgauldie
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling cloud building of multi arch images using
docker cloud builder. This uses the reusable workflow that connects to the cloud builder, builds the images and pushes directly to the existing registry (GHCR).Please note that the cloud builder is still considered experimental and is limited to it's own set of limited CI minutes (separate from GH CI). Use sparingly.
As before workflow is triggered on merges to
mainandtagsSome minor changes to the bake file were made as the target name is used as part of the image name now, so this was changed to match the existing naming convention of the image.