Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointing to legacy endpoint for model configs #178

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

dvince2
Copy link
Contributor

@dvince2 dvince2 commented Jun 7, 2024

We are currently in the midst of a major refactor on model-configurations and are changing how the endpoints will work. As this system gets integrated we've kept the old model config objects and endpoints active until we're ready to flip the switch.

Note that this PR should not be merged until HMI-Server is updated to use these endpoints correctly: DARPA-ASKEM/terarium#3802

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.95%. Comparing base (8b4507f) to head (1ec320f).
Report is 3 commits behind head on main.

Files Patch % Lines
src/SimulationService.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   83.50%   81.95%   -1.55%     
==========================================
  Files           4        4              
  Lines         673      643      -30     
==========================================
- Hits          562      527      -35     
- Misses        111      116       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvince2 dvince2 merged commit d08598e into main Jun 11, 2024
2 checks passed
@dvince2 dvince2 deleted the point-to-legacy-model-config branch June 11, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants