Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add observables support, and a couple tests for ode_system_from_amr #67

Merged
merged 1 commit into from
Jul 13, 2023
Merged

add observables support, and a couple tests for ode_system_from_amr #67

merged 1 commit into from
Jul 13, 2023

Conversation

JeffBezanson
Copy link
Collaborator

No description provided.

@JeffBezanson JeffBezanson mentioned this pull request Jul 13, 2023
Closed
joshday
joshday approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@joshday joshday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything you still want to add, or can I merge when CI goes green?

@JeffBezanson
Copy link
Collaborator Author

This works so we can merge it. Only missing piece is that the observed values aren't included in the result dataframe, but Oscar should have a fix for that soon.

@joshday joshday merged commit 46078d3 into main Jul 13, 2023
1 check passed
@joshday joshday deleted the jb/observables branch July 13, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshday joshday joshday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffBezanson @joshday