Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ts/3630 interventions for calibrate #3677

Merged
merged 29 commits into from
May 28, 2024

Conversation

Tom-Szendrey
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey commented May 22, 2024

Description

PLEASE ALSO REVIEW: DARPA-ASKEM/pyciemss-service#88

Here we are adding the interventions from the model configuration to our calibrate and optimize requests within the HMIServer.

This will mean when a user connects a model config with interventions to a calibrate node and hits run the HMISERVER will add the model config's interventions to the request without the front end needing to worry about it

Testing:

  1. User should be able to add interventions in a model config
  2. Run a simulation - and still see interventions impacting parameters
  3. Run a calibration - and now see interventions impacting parameters
  4. Run an optimization - and now see interventions impacting parameters
  5. Saving a model config from optimize will carry over previous interventions as well as include any new ones from the optimize itself.
image

@Tom-Szendrey Tom-Szendrey linked an issue May 22, 2024 that may be closed by this pull request
@Tom-Szendrey Tom-Szendrey marked this pull request as ready for review May 27, 2024 17:56
@Tom-Szendrey
Copy link
Contributor Author

@bigglesandginger can you please ensure that I have used this project-id change correctly in the few java files updated

Copy link
Contributor

@bigglesandginger bigglesandginger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

project-id stuff looks good to me

@Tom-Szendrey Tom-Szendrey merged commit d1b27c6 into main May 28, 2024
9 checks passed
@Tom-Szendrey Tom-Szendrey deleted the TS/3630-interventions-for-calibrate branch May 28, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]: Seamless Interventions for Calibration
6 participants