Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abode feature result suggestions #25

Closed
wants to merge 10 commits into from

Conversation

abodeuis
Copy link
Contributor

This PR is on top of the first pull request that contained bug fixes (#23). These are my suggestions for improving the usability of the polygon feature schema. Notes on changes are as follows:

  • All of the polygon map unit metadata fields have been moved into a single class PolygonLegend.
  • The polygon segmentation data has been condensed into a single class PolygonSegmentation.
  • PolygonLegendAndFeatureResult has been renamed to PolygonMapUnit and now contains a PolygonLegend and a List of PolygonSegmentations.
  • The Provence of a result is defined by ModelProvenance which is now tied in at PolygonLegend and PolygonSegmentation as opposed to before when it was at an individual polygon level and not at all for legend data.
  • Removed Georeferencing data from polygon data. One of the big reasons to change to this format was to decouple georeferencing from segmentation. All results should be in image coords space and independent of any georeferencing.
  • Removed the old MapUnit Fields. I don't believe that any group produces that information and don't even think that a lot of that information is even contained in the map.
  • Removed internal ids from sub-fields.

These are the changes I would like to discuss on Monday. I will also note that I have only made changed to polygon features. If the changes are accepted there can discuss following a consistent format in the line and point results.

@abodeuis abodeuis self-assigned this Apr 13, 2024
@abodeuis
Copy link
Contributor Author

Add CRS field back defaulted to CriticalMAAS:Pixel, CDR_Projection_id.

@abodeuis
Copy link
Contributor Author

add model for polygon in polygon segmentation

@jgawrilo jgawrilo marked this pull request as draft April 17, 2024 00:42
@jgawrilo jgawrilo closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants