Allows custom format width #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make format width argument in `Inspect.Algreba.format` customizable though `Config`. Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
wingyplus
commented
Sep 15, 2023
| @@ -184,8 +184,7 @@ defmodule Snapshy do | |||
| value | |||
| |> Inspect.Algebra.to_doc(inspect_options()) | |||
| |> Inspect.Algebra.group() | |||
| |> Inspect.Algebra.format(80) | |||
| |> Enum.join() | |||
There was a problem hiding this comment.
I also remove Enum.join since File.write can accept iodata. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for making this library. It help me and my team save testing time a lot. ❤️
I create this patch to custom format line width. The previous one is fixed to only
80.Why is it matter
In my daily work, I have csv table like data structure (list of list) to test in unit test, columns quite a lot, and current snapshot format width make it hard to read (but it's better than asserting in unit test!).
Comparing width at 80 vs 500:
80
500