Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.0.0 #1106

Merged
merged 215 commits into from
Nov 30, 2023
Merged

Release v3.0.0 #1106

merged 215 commits into from
Nov 30, 2023

Conversation

softcat477
Copy link
Contributor

Release v3.0.0

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

jackyyzhang03 and others added 30 commits May 25, 2023 09:11
Removed some unnecessary divs, and added some css selectors to certain elements in order to be able to add css styles.
Dependencies still need to be removed from package.json. I will do it later once this decision is finalized.
Mostly adding width and height attributes to ensure application takes up the full browser page.
Some HTML reformatting + a bunch of CSS updates (mostly related to the main Rodan navbar).
- Refactor code to support new design of the navbar navigation tree.
- Update CSS styles
- Clean up HTML
- Refactored many of the classnames used within Rodan-client. They are now more general and consistent across the application, which allowed me to remove a lot of CSS that was being applied to specific elements rather than reusable classnames.
- Overhauled the table filters. They are now always present and don't have to be selected from a dropdown in order to be visible.
- Added a lot of styles to improve the UI. Mostly related to tables and table filters.
add base.py which has the rodan task object for this job
MrMondrian and others added 23 commits August 25, 2023 11:18
- By pushing a dummy image to another ddmal's docker repo
Trigger webhook and send message to Slack
Fix typo in sending workflow failure emails
- Can't talk to iipsrv:9003 so comment out that line
- Need to specify the port when trying to connect to rodan-client
- Wait for 900 secs when establishing tcp connection with rodan-main
- Add default tags when doing make pull
Fix #1093, Fix iipsrv start script
Fixes #1102 by setting the maximum width of the model window.
Fix #1103 so testers know what to test for a new release
Fix text overflow in pop-up window
feat: Create a feature checklist on release
Copy link

github-actions bot commented Nov 21, 2023

SHA: 2351079

MEI Encoding


details
Verify these:
- No empty syllables in encoded MEI file

UI overhaul


details
Verify these:
- When two jobs are grouped, they appear in the center of the workflow builder. It would make more sense for it to created where the original jobs were.

details
Verify these:
- Ctrl + 0 to move the workflow to the center of the canvas

details
Verify these:
- Text does not overflow in resource assignment page

details
Verify these:
- New UI does happen

Interactive Classifier


details
Verify these:
- The pop up window asking for username and password when the app is opened does not show up.

details
Verify these:
- Enable using arrow keys to navigate page or classifier glyphs
- Close the edit view when no glyphs are selected

details
Verify these:
- Hide classifier glyphs by default
- The Classifier Glyphs window should be minimized when the user opens the page, giving the user the option to look at the classifier glyphs or not.

Job: Staff Distance


details
- Make sure this new job does not break.
- Job description: A new rodan job that takes in a png of a folio, and returns a json containing the approximate distance between staves, as well as the image scaling factor required to make the distance between staves 64 pixels.

Job: Text Alignment


details
- Make sure text alignment does not break

Job: RGB(PNG)


details
Check this issue does not happen
- When converting from RGBA-png to RGB, transparent information sometimes gets inverted.

Rodan Functionality


details
Verify these:
- Connections are now drawn in multiple straight horizontal and vertical line segments
- Connections are now displayed in a separate layer below workflow jobs
- User can adjust where the connection breaks from vertical to horizontal by dragging
- Include all connections when fetching workflow to simplify frontend logic

details
Verify these:
- Store user-assigned resources
- Add new view to retrieve, update, and delete workflow resource assignments
- Add new context menu item to clear all resource assignments (`RMB` -> `Clear Assigned Resources` or `Workflow` -> `Clear Assigned Resources`)

details
Verify these:
- Add a new label to a resource, go open a workflow, double-click to assign a resource to a port, filter resources using labels, and make sure the new label does show up.

details
Verify these:
-  Grey out the "Add"/"Delete" buttons if adding/deleting instances of the port would exceed a minimum/maximum.

details
Verify these:
- User funcionality is working. Can receive email notification
- Can reset password via email. 

details
Verify these:
- Show workflow error messages

@JoyfulGen
Copy link
Contributor

I tested this one:

Verify these:

  • The pop up window asking for username and password when the app is opened does not show up.

And I'm still getting the pop up window. Is there anything I should be doing differently?

@softcat477
Copy link
Contributor Author

I tested this one:

Verify these:

  • The pop up window asking for username and password when the app is opened does not show up.

And I'm still getting the pop up window. Is there anything I should be doing differently?

Confirmed it's still asking for credentials

@JoyfulGen
Copy link
Contributor

I tested this one:

Verify these:

  • Add a new label to a resource, go open a workflow, double-click to assign a resource to a port, filter resources using labels, and make sure the new label does show up.

And the resource does have the label I gave it ("hello"), but that label isn't showing up in the label(s) list. Also, none of my other resources on staging have labels. Those labels in the list come from my rodan.production, don't know how.

Hello.label.not.there.mov

@softcat477 softcat477 merged commit e5f620d into master Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants