Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust styles for all modal window #1160

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

yinanazhou
Copy link
Member

@yinanazhou yinanazhou commented Jun 4, 2024

Refs: #1156

Resolves: (#ID-of-the-issue)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

Introduce option scroll to ControllerModal to set modal window scroll or table body scroll.
Modify templates to fix the style in table headers.
Adjust layout for all modal window.

Introduce option `scroll` to `ControllerModal` to set modal window scroll or table body scroll.
Modify templates to fix the style in table headers.
Adjust layout for all modal window.

Refs: #1156
Copy link
Contributor

@homework36 homework36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on my local machine (rodan-client only)

@yinanazhou yinanazhou merged commit 56d2837 into develop Jun 4, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants