Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C Clef Extraction Job #1186

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Add C Clef Extraction Job #1186

merged 4 commits into from
Jul 10, 2024

Conversation

lucasmarchd01
Copy link
Contributor

@lucasmarchd01 lucasmarchd01 commented Jun 28, 2024

Resolves: (#ID-of-the-issue)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

(Describe the changes you've made and the purpose of this PR)

This PR adds a Rodan job that crops C Clefs from an image, given the PNG image file and an XML file generated from the Interactive Classifier job.

The output resources of this job are PNG images of C clefs, named with the original image filename and indexed.

Copy link
Contributor

@homework36 homework36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my local machine. Great job!

@homework36 homework36 self-requested a review July 9, 2024 14:43
@homework36
Copy link
Contributor

ci/dockercloud-stage has been fixed. Please update the latest changes from develop and it should work!

@lucasmarchd01 lucasmarchd01 merged commit 0a24701 into develop Jul 10, 2024
2 checks passed
@lucasmarchd01 lucasmarchd01 deleted the crop_c_clef branch July 10, 2024 15:16
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants