Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch downloading #1193

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fix batch downloading #1193

merged 1 commit into from
Jul 18, 2024

Conversation

homework36
Copy link
Contributor

@homework36 homework36 commented Jul 18, 2024

Resolves: (#1180)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

We changed the IO package and added encoding and decoding steps to make batch downloading work on resources page.

- removed six.stringIO and use BytesIO
- add proper encode and decode steps
@homework36 homework36 merged commit 4c7f761 into develop Jul 18, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants