Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.1.0 #1222

Merged
merged 48 commits into from
Nov 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
4a09cd9
Mei_encoding fix readme, delete pymei
malajvan Aug 14, 2023
7f74b64
Delete unnecessary Readmes
malajvan Aug 14, 2023
4abf095
Delete unnecessary helper scripts
malajvan Aug 14, 2023
58c3ade
Delete unnecessary test files
malajvan Aug 14, 2023
817879c
Merge pull request #1110 from DDMAL/release-v3.0.0
softcat477 Nov 30, 2023
bdfc35a
fix: fix alpine version to 3.18.5 in iipsrv
softcat477 Dec 19, 2023
ec2fe1a
Merge pull request #1119 from DDMAL/fix_iipsrv_version
softcat477 Dec 19, 2023
f0f1350
Merge branch 'develop' into del_readmes
timothydereuse Feb 9, 2024
c3b15ef
Merge pull request #1060 from DDMAL/del_readmes
timothydereuse Feb 9, 2024
b764640
fix: rewrite StaffFinding while loop and clean up
homework36 Feb 15, 2024
4297dae
fix: Adjust resource assignment modal window layout
yinanazhou Feb 20, 2024
82a230b
Merge pull request #1132 from DDMAL/fix_stafffinding
softcat477 Feb 23, 2024
89d255f
Merge pull request #1134 from DDMAL/ui-fix
yinanazhou Feb 23, 2024
40476cb
fix: adjust modal window grid and fix scroll
yinanazhou May 23, 2024
9412fe4
Merge pull request #1150 from DDMAL/modal-window-style
yinanazhou May 27, 2024
cda544f
fix: adjust styles for all modal window
yinanazhou Jun 4, 2024
56d2837
Merge pull request #1160 from DDMAL/modal-window-style
yinanazhou Jun 4, 2024
d462acb
fix: clear view on workflow delete
yinanazhou Jun 7, 2024
54aa0b6
Merge pull request #1167 from DDMAL/delete-err
yinanazhou Jun 7, 2024
abb10cd
solve name_set type error
homework36 Jun 20, 2024
954eaee
Merge pull request #1182 from DDMAL/fix_1179_IC_TypeError
homework36 Jun 20, 2024
8373467
feat(jobs): register extract c clef job
lucasmarchd01 Jun 28, 2024
f1b0042
feat(jobs): add resource name to extracted information for job resource
lucasmarchd01 Jun 28, 2024
8013bd4
feat(jobs): add c clef extraction job
lucasmarchd01 Jun 28, 2024
ac4bea4
update pip install source code url
homework36 Jul 8, 2024
d37410f
remove duplicate iipsrv build code block
homework36 Jul 8, 2024
d54e793
Merge pull request #1189 from DDMAL/fix-gpu-dockerfile
homework36 Jul 9, 2024
71eaf44
Merge branch 'develop' of https://github.com/DDMAL/Rodan into crop_c_…
lucasmarchd01 Jul 10, 2024
0a24701
Merge pull request #1186 from DDMAL/crop_c_clef
lucasmarchd01 Jul 10, 2024
7f9f8e8
fix archive create and download
homework36 Jul 18, 2024
4c7f761
Merge pull request #1193 from DDMAL/batch-download-fix
homework36 Jul 18, 2024
8504e07
fix: change default octave for C, F, and G clefs in pitch finding alg…
lucasmarchd01 Sep 16, 2024
3e0c1d7
test: add new ground truth output file for heuristic pitch finding
lucasmarchd01 Sep 16, 2024
5ba1fb7
fix(job): fix base octave for G clef
lucasmarchd01 Sep 19, 2024
a81032d
fix(job): fix base octave for G clef
lucasmarchd01 Sep 19, 2024
8807a2d
Merge branch 'fix-default-octave' of https://github.com/DDMAL/Rodan i…
lucasmarchd01 Sep 19, 2024
4e5e799
test: fix miyao staff finding test file
lucasmarchd01 Sep 19, 2024
a851c6f
Merge pull request #1208 from DDMAL/fix-default-octave
lucasmarchd01 Sep 23, 2024
7f14143
Update paco tag to v2.0.4
homework36 Oct 7, 2024
a438a65
Merge pull request #1218 from DDMAL/fix_paco_train
homework36 Oct 22, 2024
71848f9
add rename method for Resource
homework36 Oct 28, 2024
5cb1814
allow user to rename a file in resource distributor
homework36 Nov 1, 2024
e0a9c2a
modify test for resource distributor
homework36 Nov 1, 2024
a3b4d4c
fix unit test
homework36 Nov 1, 2024
249fa62
change default app type to rgba+png
homework36 Nov 4, 2024
981e8d5
modify err msg for mismatched input type
homework36 Nov 4, 2024
d65c467
Merge pull request #1221 from DDMAL/fix_outputname
homework36 Nov 4, 2024
7e1bc56
Release v3.1.0
homework36 Nov 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ REPLACE := perl -i -pe
RODAN_PATH := ./rodan-main/code/rodan
JOBS_PATH := $(RODAN_PATH)/jobs

PROD_TAG := v3.0.0
PROD_TAG := v3.1.0

DOCKER_TAG := nightly

Expand Down
5 changes: 0 additions & 5 deletions build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,3 @@ services:
dockerfile: Dockerfile
image: "ddmal/rodan-client:nightly"

iipsrv:
build:
context: ./iipsrv
dockerfile: Dockerfile
image: "ddmal/iipsrv:nightly"
2 changes: 1 addition & 1 deletion gpu-celery/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
&& \
apt-get clean && \
rm -rf /var/lib/apt/lists/* \
&& wget https://bootstrap.pypa.io/get-pip.py \
&& wget https://bootstrap.pypa.io/pip/3.7/get-pip.py \
&& ${PYTHON} get-pip.py \
&& ln -sf /usr/bin/${PYTHON} /usr/local/bin/python3 \
&& ln -sf /usr/local/bin/pip /usr/local/bin/pip3 \
Expand Down
6 changes: 3 additions & 3 deletions iipsrv/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM alpine AS builder
FROM alpine:3.18.5 AS builder

RUN apk add --no-cache \
autoconf \
Expand All @@ -15,7 +15,7 @@ RUN ./autogen.sh
RUN ./configure --enable-openjpeg
RUN make

FROM alpine
FROM alpine:3.18.5

RUN apk add --no-cache \
libgcc \
Expand All @@ -34,4 +34,4 @@ ENV PORT 9003

EXPOSE ${PORT}

ENTRYPOINT /fcgi-bin/iipsrv.fcgi --bind 0.0.0.0:${PORT}
ENTRYPOINT /fcgi-bin/iipsrv.fcgi --bind 0.0.0.0:${PORT}
12 changes: 6 additions & 6 deletions production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: "3.4"
services:

nginx:
image: "ddmal/nginx:v3.0.0"
image: "ddmal/nginx:v3.1.0"
deploy:
replicas: 1
resources:
Expand Down Expand Up @@ -37,7 +37,7 @@ services:
- "resources:/rodan/data"

rodan-main:
image: "ddmal/rodan-main:v3.0.0"
image: "ddmal/rodan-main:v3.1.0"
deploy:
replicas: 1
resources:
Expand Down Expand Up @@ -78,7 +78,7 @@ services:
- "resources:/rodan/data"

celery:
image: "ddmal/rodan-main:v3.0.0"
image: "ddmal/rodan-main:v3.1.0"
deploy:
replicas: 1
resources:
Expand Down Expand Up @@ -109,7 +109,7 @@ services:
- "resources:/rodan/data"

py3-celery:
image: "ddmal/rodan-python3-celery:v3.0.0"
image: "ddmal/rodan-python3-celery:v3.1.0"
deploy:
replicas: 1
resources:
Expand Down Expand Up @@ -139,7 +139,7 @@ services:
- "resources:/rodan/data"

gpu-celery:
image: "ddmal/rodan-gpu-celery:v3.0.0"
image: "ddmal/rodan-gpu-celery:v3.1.0"
deploy:
replicas: 1
resources:
Expand Down Expand Up @@ -195,7 +195,7 @@ services:
TZ: America/Toronto

postgres:
image: "ddmal/postgres-plpython:v3.0.0"
image: "ddmal/postgres-plpython:v3.1.0"
deploy:
replicas: 1
endpoint_mode: dnsrr
Expand Down
20 changes: 16 additions & 4 deletions rodan-client/code/src/js/Controllers/ControllerModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ export default class ControllerModal extends BaseController
$modalEl.html(this._layoutViewModal.el);
$('.modal-title').text(options.title);
$('.modal-body').append(options.content);
$('#modal-close').on('click', () => Radio.channel('rodan').request(RODAN_EVENTS.REQUEST__MODAL_HIDE));
$modalEl.show();
$('#modal-close').on('click', () => Radio.channel('rodan').request(RODAN_EVENTS.REQUEST__MODAL_HIDE));
}
else
{
Expand All @@ -85,9 +84,21 @@ export default class ControllerModal extends BaseController

$modalEl.html(this._layoutViewModal.el);
$('.modal-title').text(options.title);
$('#modal-close').on('click', () => Radio.channel('rodan').request(RODAN_EVENTS.REQUEST__MODAL_HIDE));
$modalEl.show();
$('#modal-close').on('click', () => Radio.channel('rodan').request(RODAN_EVENTS.REQUEST__MODAL_HIDE));
}

switch (options.scroll) {
case 'modal':
$('.modal-body').addClass('modal-scroll');
break;

case 'table':
$('.modal .table-responsive').css('height', '50vh');
$('.modal .table-responsive>.table>tbody').addClass('tbody-scroll');
break;
}

$modalEl.show();
}

/**
Expand All @@ -106,6 +117,7 @@ export default class ControllerModal extends BaseController
{
Radio.channel('rodan').request(RODAN_EVENTS.REQUEST__MODAL_SHOW, options);
}
$('.modal-dialog').addClass('modal-fit');
$('.modal-footer').removeClass('modal-footer-error');
}

Expand Down
2 changes: 1 addition & 1 deletion rodan-client/code/src/js/Controllers/ControllerWorkflow.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export default class ControllerWorkflow extends BaseController
// Clear the individual view (if there).
if (this._viewItem !== null && options.workflow === this._viewItem.model)
{
this._projectView.clearItemView();
this._projectView.clearCollectionItemInfoView();
}
options.workflow.destroy({success: (model) => this._handleDeleteSuccess(model, this._collection)});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ export default class ControllerWorkflowBuilder extends BaseController
var collection = new JobCollection();
collection.fetch();
var view = new ViewJobCollection({collection: collection, childViewOptions: {workflow: options.workflow}});
Radio.channel('rodan').request(RODAN_EVENTS.REQUEST__MODAL_SHOW, {content: view, title: 'Jobs'});
Radio.channel('rodan').request(RODAN_EVENTS.REQUEST__MODAL_SHOW, {content: view, title: 'Jobs', scroll: 'table'});
}

/**
Expand Down Expand Up @@ -531,7 +531,7 @@ export default class ControllerWorkflowBuilder extends BaseController
_handleRequestShowWorkflowJobPortsView(options)
{
var view = new LayoutViewControlPorts(options);
Radio.channel('rodan').request(RODAN_EVENTS.REQUEST__MODAL_SHOW, {content: view, title: 'WorkflowJob Ports'});
Radio.channel('rodan').request(RODAN_EVENTS.REQUEST__MODAL_SHOW, {content: view, title: 'WorkflowJob Ports', scroll: 'modal'});
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default class LayoutViewResourceAssignment extends Marionette.View
this._viewAssignedResources = options.viewassignedresources;

this._viewAssignedResources.collection.on('update', this._updateAssignedCount);
this.setElement('<div class="content-wrapper row-content"></div>');
this.setElement('<div class="content-wrapper row-content row-top column-middle"></div>');
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export default class LayoutViewNavigation extends Marionette.View
serverConfiguration: serverConfig,
date: serverDate,
client: Configuration.CLIENT});
Radio.channel('rodan').request(RODAN_EVENTS.REQUEST__MODAL_SHOW, {title: 'About', content: html});
Radio.channel('rodan').request(RODAN_EVENTS.REQUEST__MODAL_SHOW, {title: 'About', content: html, scroll: 'modal'});
}

/**
Expand All @@ -149,7 +149,7 @@ export default class LayoutViewNavigation extends Marionette.View
var view = new BaseViewCollection({collection: collection,
template: _.template($('#template-resourcetype_collection').text()),
childView: ViewResourceTypeDetailCollectionItem});
Radio.channel('rodan').request(RODAN_EVENTS.REQUEST__MODAL_SHOW, {title: 'Development', content: view});
Radio.channel('rodan').request(RODAN_EVENTS.REQUEST__MODAL_SHOW, {title: 'Development', content: view, scroll: 'table'});
}


Expand Down
50 changes: 43 additions & 7 deletions rodan-client/code/styles/default.css
Original file line number Diff line number Diff line change
Expand Up @@ -666,10 +666,8 @@ tbody > tr:hover {
border: 1px solid #dfdfdf;
border-radius: 5px;
background-color: #f0f0f047;
height: fit-content;
width: 100%;
overflow-x: auto;
max-height: 1000px;
overflow: scroll;
}
.project-collections {
gap: 25px;
Expand Down Expand Up @@ -708,6 +706,7 @@ tbody > tr:hover {
}
.single-project-view-collection-wrapper {
gap: 10px;
overflow: hidden;
}
.resource-upload-container {
height: fit-content;
Expand Down Expand Up @@ -938,7 +937,6 @@ div#main_workflowbuilder
animation: fade-in 0.2s ease-in-out forwards;
}
.modal-dialog {
width: fit-content;
height: fit-content;
border-radius: 3px;
position: relative;
Expand All @@ -947,7 +945,6 @@ div#main_workflowbuilder
backdrop-filter: blur(20px);
min-width: 500px;
max-width: 100%;
/* min-height: 300px; */
}
.modal-header {
align-items: center;
Expand All @@ -965,7 +962,6 @@ div#main_workflowbuilder
.modal-body
{
max-height: 600px;
overflow-y: auto;
padding: 20px;
box-sizing: border-box;
font-size: 12px;
Expand Down Expand Up @@ -993,7 +989,13 @@ div#main_workflowbuilder
.modal-body-section-left {
align-items: flex-start;
}

.modal-fit {
width: fit-content;
height: fit-content;
}
.modal-scroll {
overflow: scroll;
}
/* project-users modal styles */
#admins-and-workers-tables {
align-items: flex-start;
Expand All @@ -1010,6 +1012,10 @@ div#main_workflowbuilder
}

/* resource assignment modal */
.modal-grid {
display: grid;
grid-template-columns: 8fr 1fr 8fr;
}
#resource-assignment-actions-container {
height: fit-content;
padding: 5px;
Expand All @@ -1019,6 +1025,36 @@ div#main_workflowbuilder
max-width: 150px;
}

/* tables in modal */
.table-modal-container {
height: 45vh;
}
.table-modal {
overflow-y: scroll;
}
.table-modal>tbody {
overflow: scroll;
}
.table-modal>thead>tr>th,
.table-modal>tbody>tr>th {
max-width: 70px;
word-wrap: break-word;
}
.table-modal>thead>tr>td,
.table-modal>tbody>tr>td {
max-width: 70px;
word-wrap: break-word;
border-bottom: 1px solid rgb(215 215 215);
}
.table-modal>thead>tr>th:first-child,
.table-modal>tbody>tr>th:first-child,
.table-modal>thead>tr>td:first-child,
.table-modal>tbody>tr>td:first-child {
max-width: 180px;
}
.tbody-scroll {
overflow: scroll;
}
/* job settings modal */
#workflowjob-settings:first-child {
display: flex;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ <h3>Input Ports</h3>
<thead>
<tr>
<th>Label</th>
<th></th>
</tr>
</thead>
<tbody>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ <h3>Input Port Types</h3>
<th>Current</th>
<th>Min</th>
<th>Max</th>
<th></th>
</tr>
</thead>
<tbody>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<th data-name="category">Category</th>
<th data-name="name">Name</th>
<th data-name="interactive">Interactive</th>
<th></th>
</tr>
</thead>
<tbody>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ <h3>Output Ports</h3>
<thead>
<tr>
<th>Label</th>
<th></th>
</tr>
</thead>
<tbody>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ <h3>Output Port Types</h3>
<th>Current</th>
<th>Min</th>
<th>Max</th>
<th></th>
</tr>
</thead>
<tbody>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="table-responsive" style="overflow: auto">
<table class="table table-hover table-condensed" id="table-resources">
<div class="table-responsive table-modal-container" style="overflow: auto">
<table class="table table-hover table-condensed table-modal" id="table-resources">
<thead>
<tr>
<th data-name="name">Name</th>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="content-wrapper row-content row-left row-top row-middle flex-gap-10">
<div class="modal-grid row-left row-top row-middle flex-gap-10">
<div class="content-wrapper column-content flex-gap-10">
<div class="content-wrapper row-content row-left modal-subtitle-container">
<h3 class="text-nowrap">Available Resources</h3>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<th data-name="extension">Extension</th>
<th data-name="description">Description</th>
<th data-name="url">URL</th>
<th></th>
</tr>
</thead>
<tbody>
Expand Down
30 changes: 0 additions & 30 deletions rodan-main/code/helper_scripts/convert_image.py

This file was deleted.

Loading
Loading