Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-design 404 page #124

Merged
merged 7 commits into from
Jul 19, 2024
Merged

Re-design 404 page #124

merged 7 commits into from
Jul 19, 2024

Conversation

yinanazhou
Copy link
Member

Resolves: #123

@dchiller
Copy link
Contributor

dchiller commented Jul 19, 2024 •
edited
Loading

Looks good, but should this also resolve #119?

Edit: I see now that there are commits here that are also in #122

@yinanazhou
Copy link
Member Author

Looks good, but should this also resolve #119?

Edit: I see now that there are commits here that are also in #122

Yes, I rebased to branch animation.

@yinanazhou
Copy link
Member Author

Latest update:

image

@yinanazhou yinanazhou merged commit e81edd4 into develop Jul 19, 2024
3 checks passed
@yinanazhou yinanazhou deleted the 404-design branch July 23, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunfang98927 kunfang98927 kunfang98927 approved these changes

@dchiller dchiller dchiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design 404 page
3 participants
@yinanazhou @dchiller @kunfang98927