Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detail page UI rearrangement #129

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kunfang98927
Copy link
Contributor

@kunfang98927 kunfang98927 commented Jul 23, 2024

  • Initialize image uploading modal;
  • make image uploading & Edit buttons only display when users log in;
  • Adjust row orders: Instrument Names in Different Languages on the top; then Image; Wikidata ID, Hornbostel-Sachs Classification and MIMO Classification at the bottom;
  • Images should be smaller in the detail page;
  • UI should support displaying more than one images in the future;

Resolves: #128

@kunfang98927 kunfang98927 force-pushed the edit-instrument-info branch from a72bb0c to 6774def Compare July 23, 2024 15:53
@kunfang98927 kunfang98927 changed the title feat: initialize image uploading & name editing feat: detail page UI rearrangement Jul 23, 2024
@kunfang98927
Copy link
Contributor Author

Here is a preview for authenticated users:

image

@fujinaga
Copy link
Member

Not sure why you have two rows for names in different languages.
If I'm uploading an image of a new instrument, I would initially put a name (in a specified language), then the website would need to help me create a new Wikidata entry.
If I'm uploading an image of an existing instrument, the UMIL needs to search the Wikidata, confirm that it is the correct instrument then add that image.
If I'm adding a name of an instrument of an existing instrument, the the UMIL needs to search the Wikidata, confirm that it is the correct instrument then add that name (with the language).

I think we should separate the Display mode and Edit/Add mode.
For the Display, we may just go directly to the Wikidata page. To be discussed.

@kunfang98927
Copy link
Contributor Author

Not sure why you have two rows for names in different languages.

My understanding is: for one musical instrument, if we have names in two languages, we display two rows; if we have ten languages, we display ten rows. Is that correct?

@fujinaga
Copy link
Member

In general, yes; but if there are 100 languages, that would be unwieldy. That’s why I’m suggesting using Wikidata, which displays only a few unless the user clicks “All entered languages”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize Buttons and Image Upload Modal; Update Detail Page Structure and Image Display
2 participants