-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "Add new instrument name"; Initialize "Upload image"; #164
Open
kunfang98927
wants to merge
13
commits into
develop
Choose a base branch
from
img-upload
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
aa13e25
feat: initialize image upload UI
kunfang98927 eaca2c1
fix: update "upload img" init & remove unused css
kunfang98927 4af1fee
feat: initialize image upload UI
kunfang98927 e85db70
fix: update "upload img" init & remove unused css
kunfang98927 6c04418
fix: add "description" & "alias" fields into InstrumentName model
kunfang98927 b29e655
Merge branch 'img-upload' of https://github.com/DDMAL/VIM into img-up…
kunfang98927 364ff92
feat: add new instrument name
kunfang98927 4539e3c
fix: prettier fix
kunfang98927 f564ffb
fix: update prettier version in pre-commit
kunfang98927 fe5801c
fix: keep prettier version same as pre-commit
kunfang98927 888e84b
fix: update instrument list (add percussions)
kunfang98927 8079346
fix: refactor code for "add instrument name"
kunfang98927 bac2cc0
fix: refactor code for "add instrument name"
kunfang98927 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
...o/VIM/apps/instruments/migrations/0006_instrumentname_alias_instrumentname_description.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# Generated by Django 4.2.5 on 2024-10-04 15:30 | ||
|
||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
dependencies = [ | ||
("instruments", "0005_remove_language_wikidata_id"), | ||
] | ||
|
||
operations = [ | ||
migrations.AddField( | ||
model_name="instrumentname", | ||
name="alias", | ||
field=models.CharField( | ||
blank=True, help_text="Alternative name for the instrument" | ||
), | ||
), | ||
migrations.AddField( | ||
model_name="instrumentname", | ||
name="description", | ||
field=models.CharField( | ||
blank=True, help_text="Description of the instrument name" | ||
), | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 changes: 0 additions & 99 deletions
99
web-app/django/VIM/apps/instruments/static/instruments/css/detail.css
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer the right file name. You could probably just take out this comment and make the file name a command-line argument or a constant.