Update pagination setting #81
Conversation
kunfang98927
commented
Oct 21, 2023
kunfang98927
commented
- remove the former setting button and modal
- create a new pagination setting similar to Wikidata; three options - view 20/50/100 per page
- add "Go to xxx Page"
replace former pagination setting modal
|
I just updated the pagination setting. Maybe the review can be done after the project meeting so it's not rushed. |
|
This looks great! I have only two comments: 
I think it would be better to have "Go to Page XX" rather than "Go To XX Page". It's only European languages, so I'd be curious what other's find, but it looks better to me that way in English and when translated to Spanish and French than the way it currently is. 
I wonder if the numbers here could either have more contrast or have some kind of divider ... they run together a bit for me here. |
|
Thank you for the advice. I'm going to use 'Go to Page XXX'. Maybe I can add vertical lines between page numbers like Wikidata does. |
|
Have updated the pagination setting. Now it looks like this |
|
Looks great! |
| @@ -93,10 +94,9 @@ <h4 class="ms-3 me-2 my-auto"><small>INSTRUMENT LIST</small></h4> | |||
| </div> | |||
|
|
|||
| <div class="d-flex"> | |||
| <button type="button" class="btn me-1 px-1 py-0 justify-content-center display-btn" id="page-setting-btn" data-bs-toggle="modal" data-bs-target="#paginationModal"> | |||
| {% comment %} <button type="button" class="btn me-1 px-1 py-0 justify-content-center display-btn" id="page-setting-btn" data-bs-toggle="modal" data-bs-target="#paginationModal"> | |||
There was a problem hiding this comment.
Do you want to keep this comment in?
There was a problem hiding this comment.
It seems that we don't need the setting button at present, I'll delete it.
