Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream changes about facsimile #124

Merged
merged 33 commits into from
Dec 29, 2023
Merged

Merge upstream changes about facsimile #124

merged 33 commits into from
Dec 29, 2023

Commits on Dec 22, 2023

  1. Fixed: Dependabot warning on scipy 

    This should fix the scipy security warning by updating the dependencies for the "fonts" scripts.
    @ahankinson
    ahankinson committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    7d091c9 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2023

  1. Merge pull request #3563 from rism-digital/fixed-scipy-deps 

    Fixed: Dependabot warning on scipy
    @lpugin
    lpugin authored Dec 23, 2023
    Configuration menu
    Copy the full SHA
    30563af View commit details
    Browse the repository at this point in the history

  2. Use Doc type helpers in Toolkit and in DrawClef

    @lpugin
    lpugin committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    28b9808 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary check in FacsimileInterface::GetSurfaceY 

    * Same check is performed in Surface::GetMaxY
    @lpugin
    lpugin committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    b071364 View commit details
    Browse the repository at this point in the history

  4. Read and write staff@facs through Read/WriteFacsimileInterface 

    * Also remove call to Read/WriteFacsimileInterface in LayerElement child classes
    @lpugin
    lpugin committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    d8600ed View commit details
    Browse the repository at this point in the history

  5. Add FacsimileInterface to Measure

    @lpugin
    lpugin committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    24bc829 View commit details
    Browse the repository at this point in the history

  6. Add FacsimileInterface getters to Measure

    @lpugin
    lpugin committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    da9470f View commit details
    Browse the repository at this point in the history

  7. Add Doc::SyncFromFacsimileDoc and implement functor

    @lpugin
    lpugin committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    dabd14b View commit details
    Browse the repository at this point in the history

  8. Fix missing Read/Write zone coordinated ul

    @lpugin
    lpugin committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    70b1646 View commit details
    Browse the repository at this point in the history

  9. Fix overlooked Doc type helper

    @lpugin
    lpugin committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    cdc8cab View commit details
    Browse the repository at this point in the history

  10. Initial implementation of call to SyncFromFacsimileDoc

    @lpugin
    lpugin committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    f3ac85b View commit details
    Browse the repository at this point in the history

  11. Add FacsimileInterface to Pb and Sb

    @lpugin
    lpugin committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    6742a01 View commit details
    Browse the repository at this point in the history

  12. Sync Pb facsimile in SyncFromFacsimile functor 

    * Placeholder for sb but not tested nor enabled
    @lpugin
    lpugin committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    808aa9d View commit details
    Browse the repository at this point in the history

  13. Scaffold SyncFromFacsimileFunctor

    @lpugin
    lpugin committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    a1a7a93 View commit details
    Browse the repository at this point in the history

  14. Fix format

    @lpugin
    lpugin committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    44e8365 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Implement SyncToFacsimile

    @lpugin
    lpugin committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    85c6b51 View commit details
    Browse the repository at this point in the history

  2. Read sb@facs

    @lpugin
    lpugin committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    aa34af4 View commit details
    Browse the repository at this point in the history

  3. Call SyncToFacsimileDoc (testing) 

    * To be reverted
    @lpugin
    lpugin committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    220f0fb View commit details
    Browse the repository at this point in the history

  4. Remove FunctorParams old mentions 

    * Clang formatting
    @lpugin
    lpugin committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    065805f View commit details
    Browse the repository at this point in the history

  5. Allow surface within surface 

    * Not MEI valid structure
    @lpugin
    lpugin committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    4cc1e83 View commit details
    Browse the repository at this point in the history

  6. Read and write att.coordinated.ul in Surface (missing)

    @lpugin
    lpugin committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    af4fe04 View commit details
    Browse the repository at this point in the history

  7. Output facsimile with nested surface (invalid MEI)

    @lpugin
    lpugin committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    8a4a76a View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Add pseudo functors to FacsimileInterface

    @lpugin
    lpugin committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    82845f9 View commit details
    Browse the repository at this point in the history

  2. Make sure ResetData parent is always called 

    * Also add call to FascimileInterface::ResetDataInterface
    @lpugin
    lpugin committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    0eb3ce4 View commit details
    Browse the repository at this point in the history

  3. Revert "Allow surface within surface" 

    This reverts commit 4cc1e83.
    @lpugin
    lpugin committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    238e3bb View commit details
    Browse the repository at this point in the history

  4. Make a separate Doc::UpdatePageDrawingSizes method

    @lpugin
    lpugin committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    3a5dda7 View commit details
    Browse the repository at this point in the history

  5. Adjust the implementation of SyncFromFacsimile 

    * Read page size from the surface attributes
* Convert to logical units
    @lpugin
    lpugin committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    64110d1 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #3564 from DDMAL/develop 

    Integrate lates changes from DDMAL
    @lpugin
    lpugin authored Dec 28, 2023
    Configuration menu
    Copy the full SHA
    dab41c5 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into develop-facsimile

    @lpugin
    lpugin committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    bf6a3cf View commit details
    Browse the repository at this point in the history

  8. Remove unused vrv_params_cast

    @lpugin
    lpugin committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    ca05528 View commit details
    Browse the repository at this point in the history

  9. Add mei-facs output option in the command-line tool

    @lpugin
    lpugin committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    cc9269d View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. Move call to Doc::SyncFromFacsimile to Toolkit::LoadData

    @lpugin
    lpugin committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    972ae2c View commit details
    Browse the repository at this point in the history

  2. Rename m_*Abs members to m_drawingFacs*

    @lpugin
    lpugin committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    6d05ef6 View commit details
    Browse the repository at this point in the history