Skip to content

refactor: move impl of GrantsLayer to core crate (#84) #194

refactor: move impl of GrantsLayer to core crate (#84)

refactor: move impl of GrantsLayer to core crate (#84) #194

Triggered via push March 10, 2024 21:18
Status Success
Total duration 6m 43s
Artifacts

ci.yml

on: push
Clippy check
1m 22s
Clippy check
Rustfmt check
12s
Rustfmt check
PR name check
0s
PR name check
Matrix: build_and_test
Fit to window
Zoom out
Zoom in

Annotations

29 warnings
Rustfmt check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rustfmt check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
bound is defined in more than one place: rocket-grants/src/fairing.rs#L87
warning: bound is defined in more than one place --> rocket-grants/src/fairing.rs:87:30 | 87 | pub fn with_extractor_fn<F: Send + Sync + 'static>(extractor_fn: F) -> Self | ^ 88 | where 89 | F: for<'a> Fn(&'a mut Request<'_>) -> BoxFuture<'a, Option<HashSet<Type>>>, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default
you are explicitly cloning with `.map()`: actix-web-grants/src/authorities/mod.rs#L88
warning: you are explicitly cloning with `.map()` --> actix-web-grants/src/authorities/mod.rs:88:13 | 88 | / req.extensions() 89 | | .get::<AuthDetails<T>>() 90 | | .map(AuthDetails::clone) | |________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default help: consider calling the dedicated `cloned` method | 88 ~ req.extensions() 89 + .get::<AuthDetails<T>>().cloned() |
the item `ServiceRequest` is imported redundantly: actix-web-grants/src/authorities/extractors.rs#L42
warning: the item `ServiceRequest` is imported redundantly --> actix-web-grants/src/authorities/extractors.rs:42:9 | 41 | use super::*; | -------- the item `ServiceRequest` is already imported here 42 | use actix_web::dev::ServiceRequest; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
the item `jsonwebtoken` is imported redundantly: actix-web-grants/examples/jwt-httpauth/claims.rs#L4
warning: the item `jsonwebtoken` is imported redundantly --> actix-web-grants/examples/jwt-httpauth/claims.rs:4:20 | 4 | use jsonwebtoken::{self, DecodingKey, EncodingKey, Header, Validation}; | ^^^^ the item `jsonwebtoken` is already defined by prelude | = note: `#[warn(unused_imports)]` on by default
the item `jsonwebtoken` is imported redundantly: poem-grants/examples/jwt-auth/claims.rs#L2
warning: the item `jsonwebtoken` is imported redundantly --> poem-grants/examples/jwt-auth/claims.rs:2:20 | 2 | use jsonwebtoken::{self, DecodingKey, EncodingKey, Header, Validation}; | ^^^^ the item `jsonwebtoken` is already defined by prelude | = note: `#[warn(unused_imports)]` on by default
you are explicitly cloning with `.map()`: poem-grants/src/authorities/mod.rs#L82
warning: you are explicitly cloning with `.map()` --> poem-grants/src/authorities/mod.rs:82:9 | 82 | / req.extensions() 83 | | .get::<AuthDetails<T>>() 84 | | .map(AuthDetails::clone) | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default help: consider calling the dedicated `cloned` method | 82 ~ req.extensions() 83 + .get::<AuthDetails<T>>().cloned() |
bound is defined in more than one place: rocket-grants/src/fairing.rs#L87
warning: bound is defined in more than one place --> rocket-grants/src/fairing.rs:87:30 | 87 | pub fn with_extractor_fn<F: Send + Sync + 'static>(extractor_fn: F) -> Self | ^ 88 | where 89 | F: for<'a> Fn(&'a mut Request<'_>) -> BoxFuture<'a, Option<HashSet<Type>>>, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default
you are explicitly cloning with `.map()`: actix-web-grants/src/authorities/mod.rs#L88
warning: you are explicitly cloning with `.map()` --> actix-web-grants/src/authorities/mod.rs:88:13 | 88 | / req.extensions() 89 | | .get::<AuthDetails<T>>() 90 | | .map(AuthDetails::clone) | |________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default help: consider calling the dedicated `cloned` method | 88 ~ req.extensions() 89 + .get::<AuthDetails<T>>().cloned() |
the item `jsonwebtoken` is imported redundantly: rocket-grants/examples/jwt-auth/claims.rs#L2
warning: the item `jsonwebtoken` is imported redundantly --> rocket-grants/examples/jwt-auth/claims.rs:2:20 | 2 | use jsonwebtoken::{self, DecodingKey, EncodingKey, Header, Validation}; | ^^^^ the item `jsonwebtoken` is already defined by prelude | = note: `#[warn(unused_imports)]` on by default
you are explicitly cloning with `.map()`: poem-grants/src/authorities/mod.rs#L82
warning: you are explicitly cloning with `.map()` --> poem-grants/src/authorities/mod.rs:82:9 | 82 | / req.extensions() 83 | | .get::<AuthDetails<T>>() 84 | | .map(AuthDetails::clone) | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default help: consider calling the dedicated `cloned` method | 82 ~ req.extensions() 83 + .get::<AuthDetails<T>>().cloned() |
bound is defined in more than one place: rocket-grants/src/fairing.rs#L87
warning: bound is defined in more than one place --> rocket-grants/src/fairing.rs:87:30 | 87 | pub fn with_extractor_fn<F: Send + Sync + 'static>(extractor_fn: F) -> Self | ^ 88 | where 89 | F: for<'a> Fn(&'a mut Request<'_>) -> BoxFuture<'a, Option<HashSet<Type>>>, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default
you are explicitly cloning with `.map()`: actix-web-grants/src/authorities/mod.rs#L88
warning: you are explicitly cloning with `.map()` --> actix-web-grants/src/authorities/mod.rs:88:13 | 88 | / req.extensions() 89 | | .get::<AuthDetails<T>>() 90 | | .map(AuthDetails::clone) | |________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default help: consider calling the dedicated `cloned` method | 88 ~ req.extensions() 89 + .get::<AuthDetails<T>>().cloned() |
you are explicitly cloning with `.map()`: poem-grants/src/authorities/mod.rs#L82
warning: you are explicitly cloning with `.map()` --> poem-grants/src/authorities/mod.rs:82:9 | 82 | / req.extensions() 83 | | .get::<AuthDetails<T>>() 84 | | .map(AuthDetails::clone) | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default help: consider calling the dedicated `cloned` method | 82 ~ req.extensions() 83 + .get::<AuthDetails<T>>().cloned() |
Clippy check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build & Test - Ubuntu (stable)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build & Test - Ubuntu (stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build & Test - Ubuntu (nightly)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build & Test - Ubuntu (nightly)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build & Test - MacOS (nightly)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build & Test - MacOS (nightly)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build & Test - Windows (nightly)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build & Test - Windows (nightly)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build & Test - Windows (stable)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build & Test - Windows (stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build & Test - MacOS (stable)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build & Test - MacOS (stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/