Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

63 python the underflow thread does not stop itself #66

Merged
merged 2 commits into from
Aug 28, 2024
Merged

63 python the underflow thread does not stop itself #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
804cb36
#63 Add stopping to underflow detection
magoorden Aug 28, 2024
f5583f0
#63 Add method description
magoorden Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions py_driver/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,10 @@ def update_state(self, tube=None, quick=False, initial=False):
raise SensorError(f"Failed to retrieve new state, got {state}.")

def _underflow_check(self):
"""
Checks whether underflow occurs, i.e., the outflow pump is pumping while water is lower than
lowest allowed level. This check prevents the outflow pump from pumping air.
"""
TAG = "UNDERFLOW_CHECK"
while True:
if not self.ready():
Expand Down Expand Up @@ -274,6 +278,11 @@ def _underflow_check(self):
else:
if DEBUG:
print(f'{TAG}: No underflow detected in watchdog.')

# Stop checking underflow.
if self.stopped:
break

sleep(UNDERFLOW_CHECK_INTERVAL)

def _read_lines(self):
Expand Down
Loading