Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eigen clear() missing method #1665

Closed
wants to merge 6 commits into from

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Oct 30, 2022

PR Description

From using DGtal with ITK that use and transmit its own Eigen version it produces already detected clear() missing method.
As mentionnes in DGtalTools in issue 354 of DGtalTools.
It fix both compilation issues of DGtal examples with ITK and the volSurfaceRegularization of DGtalTools.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions & appveyor)

@dcoeurjo
Copy link
Member

Touching the concept may be a bit dangerous. Are there classes / codes using a clear() on the linear algebra backends ?

@kerautret
Copy link
Member Author

Touching the concept may be a bit dangerous. Are there classes / codes using a clear() on the linear algebra backends ?

yes, mainly in dec with k-forms if I am not wrong. Alternatively perhaps we can extend the type by integrating the clear() method in order to be conform to CVectorSpace requirements. Trying to avoid ITK transmit its own eigen path should be perhaps not very useful since sooner or later it will produce the same error with newer eigen version.

@dcoeurjo
Copy link
Member

If it's fine for you, I'll keep this to the release 1.4 or 1.3.1, we need to inspect the sideeffects of that (I suspect cmake tweaks to isolate ITK's Eigen)

@kerautret
Copy link
Member Author

yes fine for me, it was just a few edit, I will try the add of clear() alternative perhaps safer but perhaps more on 1.3.1 or 1.4

@dcoeurjo
Copy link
Member

dcoeurjo commented Mar 9, 2023

Actually, I had the same itk issue for #1689 and I also had to fix that (the clear() is not a method of the matrix class anymore apparently).. Thanks for the PR and the bug report, I will close this one to avoid conflicts.

Eigen deps in DGtal is still a bit odd with Eigen behind required by DGTal, and also installed by polyscope and ITK ..

@dcoeurjo dcoeurjo closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants