add _ to allowed chars

.gitignore

@@ -8,6 +8,7 @@ typechain-types
 # Hardhat files
 cache
 artifacts
+*Old.sol
 
 # OpenZeppelin
 .openzeppelin/unknown-*.json

contracts/DcnManager.sol

@@ -218,17 +218,18 @@ contract DcnManager is
         if (labelLength < 3) revert InvalidLength();
         if (labelLength > 15) revert InvalidLength();
 
-        bytes1 bLetter;
+        bytes1 bChar;
         for (uint256 i = 0; i < labelLength; i++) {
-            bLetter = b[i];
+            bChar = b[i];
 
             // A-Z
-            if (bLetter > 0x40 && bLetter < 0x5B) {
+            if (bChar > 0x40 && bChar < 0x5B) {
                 // To lowercase
-                b[i] = bLetter | 0x20;
+                b[i] = bChar | 0x20;
             } else if (
-                !(bLetter > 0x2F && bLetter < 0x3A) && // 9-0
-                !(bLetter > 0x60 && bLetter < 0x7B) // a-z
+                !(bChar > 0x2F && bChar < 0x3A) && // 9-0
+                !(bChar > 0x60 && bChar < 0x7B) && // a-z
+                !(bChar == 0x5F) // _
             ) {
                 revert InvalidCharacter();
             }

test/DcnManager.test.ts

@@ -154,6 +154,18 @@ describe('DcnManager', () => {
     });
 
     context('State', () => {
+      it('Should mint a name with all allowed characters', async () => {
+        const { user1, dcnManager, dcnRegistry } = await loadFixture(setupTldMinted);
+
+        await dcnManager
+          .connect(user1)
+          .mint(user1.address, C.MOCK_LABELS, C.ONE_YEAR, 0);
+
+        const latestBlock = await time.latestBlock();
+        const newNode = (await dcnRegistry.queryFilter(dcnRegistry.filters.NewNode(), latestBlock))[0].args.node;
+
+        expect(newNode).to.be.equal(namehash(C.MOCK_LABELS));
+      });
       it('Should convert uppercase to lowercase', async () => {
         const { user1, dcnManager, dcnRegistry } = await loadFixture(setupTldMinted);
 

utils/constants.ts

@@ -34,14 +34,14 @@ export const DCN_REGISTRY_NFT_BASE_URI = 'https://dimo.zone/dcn/';
 
 export const MOCK_INVALID_TLD = 'invalidtld';
 export const MOCK_TLD = 'dimo';
-export const MOCK_LABELS = ['label1', 'dimo'];
-export const MOCK_LABELS_UPPERCASE = ['LABEL1', 'dimo'];
+export const MOCK_LABELS = ['label_1', 'dimo'];
+export const MOCK_LABELS_UPPERCASE = ['LABEL_1', 'dimo'];
 
 // Invalid labels
-export const MOCK_LABELS_3 = ['label2', 'label1', 'dimo'];
+export const MOCK_LABELS_3 = ['label_2', 'label_1', 'dimo'];
 export const MOCK_LABELS_SHORT = ['l', 'dimo'];
 export const MOCK_LABELS_LONG = ['labelabelabelabelabelabelabel', 'dimo'];
-export const MOCK_LABELS_WRONG_CHARS = ['Ln57&%_', 'dimo'];
+export const MOCK_LABELS_WRONG_CHARS = ['Ln57&%', 'dimo'];
 
 // Disallowed labels
 export const MOCK_DISALLOWED_LABEL_1 = 'disallowed1';