Intial Commit Review. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elffjs
reviewed
Mar 4, 2024
| } | ||
| defer func() { | ||
| if cerr := goOutputFile.Close(); err == nil && cerr != nil { | ||
| err = cerr |
There was a problem hiding this comment.
No good catch I need to make err a named return for it to bubble up.
elffjs
reviewed
Mar 4, 2024
|
|
||
| // Derived | ||
| IsArray bool | ||
| GOName string |
elffjs
reviewed
Mar 4, 2024
internal/codegen/codegen.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| ClickhouseFileName = "vss-table.sql" |
There was a problem hiding this comment.
Yeah this is actually a subset of my personal one I will grab one of config files we use in another repo.
elffjs
reviewed
Mar 4, 2024
internal/codegen/codegen.go
Outdated
| package codegen | ||
|
|
||
| import ( | ||
| _ "embed" |
There was a problem hiding this comment.
I swear there's an exception for this one in the linter.
There was a problem hiding this comment.
I used to have the templates embedded in this file before I moved them to separate packages, so this import was an artifact.
* Fixed .gitignore to ignore codegen binary only. * Added generation of convert test functions. * Update comments for generated code. * Updated conversion for SupportedFuleTypes * Added Transmission.FuelType.
elffjs
reviewed
Mar 5, 2024
schema/migrations.json
Outdated
Comment on lines
41
to
48
| "originalName": "data.vehicleID", | ||
| "originalType": "string" | ||
| } | ||
| }, | ||
| { | ||
| "vspecName": "Vehicle.DIMO.DefinitionID", | ||
| "conversion": { | ||
| "originalName": "data.definitionID", |
* Removed root prefixes from model and column names. * Root prefix is used for the model name instead of `vehicle`. * file names are updated to match the model name. * table name matches the root prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows anyone to make comments or suggestions on the initial code.