-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add power signal; somewhat limited #15
Add power signal; somewhat limited #15
Conversation
@KevinJoiner What command should I be running here? I copied the README and got
|
I think one does want to add |
I see, it's because It seems like |
@@ -58,6 +58,8 @@ const ( | |||
FieldPowertrainTractionBatteryChargingChargeLimit = "powertrainTractionBatteryChargingChargeLimit" | |||
// FieldPowertrainTractionBatteryChargingIsCharging True if charging is ongoing. Charging is considered to be ongoing if energy is flowing from charger to vehicle. | |||
FieldPowertrainTractionBatteryChargingIsCharging = "powertrainTractionBatteryChargingIsCharging" | |||
// FieldPowertrainTractionBatteryCurrentPower Current electrical energy flowing in/out of battery. Positive = Energy flowing in to battery, e.g. during charging. Negative = Energy flowing out of battery, e.g. during driving. | |||
FieldPowertrainTractionBatteryCurrentPower = "powertrainTractionBatteryCurrentPower" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to take this opportunity to also populate powertrainTractionBatteryChargingIsCharging
if we're seeing a positive value here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry that cross-talk between the fields will not fit into the code generation. I haven’t tried to verify this suspicion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codegen should handle multiple signals being populated from the same data point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Speaking lazily: we only get this for Tesla, and we're for sure populating charging
for those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make generate
will generate the code for this repo I can update the readme with make help.
@@ -58,6 +58,8 @@ const ( | |||
FieldPowertrainTractionBatteryChargingChargeLimit = "powertrainTractionBatteryChargingChargeLimit" | |||
// FieldPowertrainTractionBatteryChargingIsCharging True if charging is ongoing. Charging is considered to be ongoing if energy is flowing from charger to vehicle. | |||
FieldPowertrainTractionBatteryChargingIsCharging = "powertrainTractionBatteryChargingIsCharging" | |||
// FieldPowertrainTractionBatteryCurrentPower Current electrical energy flowing in/out of battery. Positive = Energy flowing in to battery, e.g. during charging. Negative = Energy flowing out of battery, e.g. during driving. | |||
FieldPowertrainTractionBatteryCurrentPower = "powertrainTractionBatteryCurrentPower" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codegen should handle multiple signals being populated from the same data point
For Teslas, we have this field
charger.power
:In kilowatts. This is only populated during charging. Looking at VSS, the best match seems to be
Powertrain.TractionBattery.CurrentPower
. Two weird things: