Fix typo: boolean, not Boolean in the VSS type system #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use the same parameter name as the Go converter
elffjs
commented
Jun 7, 2024
| @@ -187,8 +187,8 @@ func splitAndSantizeName(name string) (string, string) { | |||
| } | |||
|
|
|||
| // goTypeFromVSPEC converts vspec type to golang types. | |||
| func goTypeFromVSPEC(dataType string) string { | |||
| switch dataType { | |||
There was a problem hiding this comment.
Trying to make them match.
elffjs
commented
Jun 7, 2024
| @@ -199,7 +199,8 @@ func goTypeFromVSPEC(dataType string) string { | |||
| // gqlTypeFromVSPEC converts vspec type to graphql types. | |||
| func gqlTypeFromVSPEC(baseType string) string { | |||
| switch baseType { | |||
| case "uint8", "int8", "uint16", "int16", "uint32", "int32", "float", "double", "uint64", "int64", "Boolean": | |||
| // TODO(elffjs): Unify the lists between here and goTypeFromVSPEC? | |||
| case "uint8", "int8", "uint16", "int16", "uint32", "int32", "uint64", "int64", "float", "double", "boolean": | |||
There was a problem hiding this comment.
I reordered the list to match, but the big thing is the casing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use the same parameter name as the Go converter