-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AS-3125 Map current set of Tesla fields #94
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elffjs
changed the title
As 3125 first set of tesla mappings
AS-3125 Map current set of Tesla fields
Nov 4, 2024
KevinJoiner
approved these changes
Nov 13, 2024
pkg/tesla/status/convert.go
Outdated
|
||
func Decode(msgBytes []byte) ([]vss.Signal, error) { | ||
// Only interested in the top-level CloudEvent fields. | ||
var ce cloudevent.CloudEvent[struct{}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
var ce cloudevent.CloudEvent[struct{}] | |
var ce cloudevent.CloudEventHeader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Let's do that.
In truth, we care about two fields and we could probably just select those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce raw Tesla payload translation. We assume that we are given a CloudEvent
Here we only add the signals that we presently parse out from Tesla, along with one more: the amount of energy added to the battery during an active charging session.
Following Ruptela, there's a new
pkg/tesla/schema/tesla-definitions.yaml
and a new make targetgenerate-tesla
.Conversion oddities: